Skip to content

fix: surface nested mapping errors#426

Merged
george-zubrienko merged 4 commits intolidatong:masterfrom
skeggse:fix-nested-mapping-decode
Jun 23, 2023
Merged

fix: surface nested mapping errors#426
george-zubrienko merged 4 commits intolidatong:masterfrom
skeggse:fix-nested-mapping-decode

Conversation

@skeggse
Copy link
Contributor

@skeggse skeggse commented Jun 16, 2023

Fixes #425.

@skeggse
Copy link
Contributor Author

skeggse commented Jun 16, 2023

The mypy errors look like they're already present on master, but I haven't carefully examined them.

@george-zubrienko
Copy link
Collaborator

The mypy errors look like they're already present on master, but I haven't carefully examined them.

This is not a required check yet. You can ignore this for now :)

Copy link
Collaborator

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse, you can ignore errors in mypy for now, we will fix them. Let's fix the test and merge it :)

skeggse added 2 commits June 20, 2023 11:25
I learned a new thing about pytest today
@skeggse skeggse requested a review from s-vitaliy June 21, 2023 20:46
@george-zubrienko george-zubrienko merged commit 8ffa594 into lidatong:master Jun 23, 2023
@skeggse skeggse deleted the fix-nested-mapping-decode branch October 2, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] common errors from decoder on inner dataclass silently ignored

3 participants